hgeraldino commented on PR #14663: URL: https://github.com/apache/kafka/pull/14663#issuecomment-1913670929
Thanks @gharris1727 for your thorough review. I've addressed most of yours (and @C0urante's) comments. One thing I didn't address was refactoring the `testErrorInRebalance*` tests, they have small variances that are tricky to abstract. We can take another stab once we move these to JUnit5, the APIs for parameterized tests are much nicer than those in JUnit4. Please take another look and let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
