pprovenzano commented on code in PR #15232:
URL: https://github.com/apache/kafka/pull/15232#discussion_r1469006939
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1408,6 +1408,7 @@ void handleDirectoriesOffline(
(short) 2));
log.warn("Directories {} in broker {} marked offline, remaining
directories: {}",
newOfflineDirs, brokerId, newOnlineDirs);
+ // XXX If the result of this is the broker has no online
directories then fence.
Review Comment:
In the bug case, yes they would always be empty but this is the update for
the heartbeat and should only be called if a directory goes offline in a
broker.
However in the bug case there can only be one directory on the broker in 3.6
so the broker should never send a heartbeat that would call this path. Instead
since the last directory of the broker went offline (it only has one) the
broker should fail. Adding code here would be just an extra protection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
