OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469691076
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -183,7 +183,7 @@ object HostedPartition {
/**
* This broker hosts the partition, but it is in an offline log directory.
*/
- final object Offline extends HostedPartition
+ final case class Offline(topicId: Option[Uuid]) extends HostedPartition
Review Comment:
Should this instead be `TopicIdPartition` as `Offline` here represent a
partition and not a topic per-say?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
