rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1470555356
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -452,21 +453,38 @@ public Group group(String groupId, long committedOffset)
throws GroupIdNotFoundE
/**
* Get the Group List.
*
- * @param statesFilter The states of the groups we want to list.
- * If empty all groups are returned with their state.
- * @param committedOffset A specified committed offset corresponding to
this shard
+ * @param statesFilter The states of the groups we want to list.
+ * If empty, all groups are returned with their
state.
+ * @param typesFilter The types of the groups we want to list.
+ * If empty, all groups are returned with their
type.
+ * @param committedOffset A specified committed offset corresponding to
this shard.
*
* @return A list containing the ListGroupsResponseData.ListedGroup
*/
+ public List<ListGroupsResponseData.ListedGroup> listGroups(
+ Set<String> statesFilter,
+ Set<String> typesFilter,
+ long committedOffset
+ ) {
+ // Converts each string to a value in the GroupType enum while being
case-insensitive.
+ Set<Group.GroupType> enumTypesFilter = typesFilter.stream()
+ .map(Group.GroupType::parse)
+ .collect(Collectors.toSet());
Review Comment:
I initially threw the illegalArgException and then caught it and ignored it
in the listGroups method but this caused the opposite result from what we
wanted aka it returns all the groups since the typeFilter is empty. The only
way to get the expected behavior is to add unknown to the group type enum. This
gives us the same result as when an unknown state filter is passed. I even
added tests to make sure. Lmk if this doesn't work or if there was something
else you had in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
