showuon commented on code in PR #15287:
URL: https://github.com/apache/kafka/pull/15287#discussion_r1470886069
##########
docs/ops.html:
##########
@@ -4045,7 +4045,7 @@ <h3>Reverting to ZooKeeper mode During the Migration</h3>
<li>
On each broker, remove the
<code>zookeeper.metadata.migration.enable</code>,
<code>controller.listener.names</code>, and
<code>controller.quorum.voters</code>
- configurations, and replace <code>node.id</code> with
<code>broker.id</code>.
+ configurations.
Review Comment:
Good catch! Should we do the same thing for `Migrating brokers to KRaft`
state?
I'm thinking in the 1st step of `Migrating brokers to KRaft`, it should add
`replace the broker.id with node.id`, ex:
```
On each broker, remove the <code>process.roles</code>, replace the
<code>node.id</code> with <code>broker.id</code>, and restore the...
```
And then, in the last step , we can also remove the `and replace
<code>node.id</code> with <code>broker.id</code>` sentence as above. WDYT?
##########
docs/ops.html:
##########
@@ -4054,7 +4054,7 @@ <h3>Reverting to ZooKeeper mode During the Migration</h3>
</ul>
</td>
<td>
- It is important to perform the <code>zookeeper-shell.sh</code> step
quickly, to minimize the amount of
+ It is important to perform the <code>zookeeper-shell.sh</code> step
quickly together with rolling at least one broker, to minimize the amount of
Review Comment:
nit: together with rolling at least one broker [into pure zookeeper mode]
<-- to make it clear that rolling the broker for what.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
