jolshan commented on code in PR #15237:
URL: https://github.com/apache/kafka/pull/15237#discussion_r1473219011
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -903,6 +906,45 @@ public boolean cleanupExpiredOffsets(String groupId,
List<Record> records) {
return allOffsetsExpired.get() &&
!openTransactionsByGroup.containsKey(groupId);
}
+ /**
+ * Remove offsets of the partitions that have been deleted.
+ *
+ * @param topicPartitions The partitions that have been deleted.
+ * @return The list of tombstones (offset commit) to append.
+ */
+ public List<Record> onPartitionsDeleted(
Review Comment:
Thanks for the thorough response. Makes sense to me. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
