mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1478422740


##########
tests/kafkatest/services/console_consumer.py:
##########
@@ -210,7 +210,10 @@ def start_cmd(self, node):
 
         # LoggingMessageFormatter was introduced after 0.9
         if node.version > LATEST_0_9:
-            cmd += " --formatter 
org.apache.kafka.tools.consumer.LoggingMessageFormatter"
+            if node.version > LATEST_3_7:
+                cmd += " --formatter 
org.apache.kafka.tools.consumer.LoggingMessageFormatter"
+            else:
+                cmd += " --formatter kafka.tools.LoggingMessageFormatter"

Review Comment:
   `LoggingMessageFormatter`,  `DefaultMessageFormatter`, 
`NoOpMessageFormatter` are not part of the public API and as far as I can tell 
the class names are not visible anywhere so this shouldn't be considered an API 
change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to