AndrewJSchofield commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1479506790
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ########## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) { this.lastSentMs = currentTimeMs; } + /** + * Update the lastReceivedTime in milliseconds, indicating that a response has been received. + */ + public void updateLastReceivedTime(final long lastReceivedMs) { + this.lastReceivedMs = lastReceivedMs; Review Comment: You're probably right @dajac. Should we be applying exponential backoff for heartbeats? Does it only apply to a subset of errors? As a starting position, I would have said that any response or error updates the last receive time, and we would apply exponential backoff in all cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org