ijuma commented on code in PR #10826:
URL: https://github.com/apache/kafka/pull/10826#discussion_r850506417
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -188,6 +190,12 @@ public class ProducerConfig extends AbstractConfig {
+ " values are
<code>none</code>, <code>gzip</code>, <code>snappy</code>, <code>lz4</code>, or
<code>zstd</code>. "
+ "Compression is of
full batches of data, so the efficacy of batching will also impact the
compression ratio (more batching means better compression).";
+ /** <code>compression.level</code> */
+ public static final String COMPRESSION_LEVEL_CONFIG = "compression.level";
+ private static final String COMPRESSION_LEVEL_DOC = "The compression level
for all data generated by the producer. The default level and valid value is up
to "
+ + "compression.type. (<code>none</code>, <code>snappy</code>: not
available. <code>gzip</code>: 1~9. <code>lz4</code>: 1~17. "
Review Comment:
I think the reason why @dongjinleekr didn't include those is that they may
change at the compression library level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
