mimaison commented on code in PR #14631: URL: https://github.com/apache/kafka/pull/14631#discussion_r1481826420
########## docs/ops.html: ########## @@ -3819,6 +3819,12 @@ <h3>Provisioning the KRaft controller quorum</h3> # ZooKeeper client configuration zookeeper.connect=localhost:2181 +# The inter broker listener in brokers to allow KRaft controller send RPCs to brokers +inter.broker.listener.name=PLAINTEXT + +# Maps listener names to security protocols. Please add the inter broker listener protocol mapping Review Comment: Not sure if we need to add this. I assumed this config to be in the `Other configs` section mentioned below as it's not specific to the migration. The goal is not to provide a full controller configuration here but to list the key configs for the migration. ########## docs/ops.html: ########## @@ -3898,6 +3904,12 @@ <h3>Migrating brokers to KRaft</h3> # Remove ZooKeeper client configuration # zookeeper.connect=localhost:2181 +# Remove the inter broker listener in brokers to allow KRaft controller send RPCs to brokers +# inter.broker.listener.name=PLAINTEXT + +# Maps listener names to security protocols. Please add the inter broker listener protocol mapping +# listener.security.protocol.map=PLAINTEXT:PLAINTEXT,CONTROLLER:PLAINTEXT + Review Comment: I think this change should be removed. This configuration should not be removed and it's already set above online 3896. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
