rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1482258074
########## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ########## @@ -2804,8 +2804,8 @@ public void testListConsumerGroupsWithStates() throws Exception { Review Comment: 1) Added version check 3) Tested variation one withTypes and one without, should I also add them to the states methods in this PR? > We need to test the basic plumbing. can you please elaborate? ########## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ########## @@ -2804,8 +2804,8 @@ public void testListConsumerGroupsWithStates() throws Exception { Review Comment: 1) Added version check 3) Tested variation one withTypes and one without, should I also add them to the states methods in this PR? > We need to test the basic plumbing. can you please elaborate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org