jlprat commented on code in PR #15338:
URL: https://github.com/apache/kafka/pull/15338#discussion_r1482585039
##########
build.gradle:
##########
@@ -2355,7 +2366,7 @@ project(':streams:streams-scala') {
spotless {
scala {
target '**/*.scala'
-
scalafmt("$versions.scalafmt").configFile('../../checkstyle/.scalafmt.conf').scalaMajorVersion(versions.baseScala)
+
scalafmt("$versions.scalafmt").configFile('../../checkstyle/.scalafmt.conf').scalaMajorVersion('2.13')
Review Comment:
What's the motivation for this change? This means that we would run scalafmt
with 2.13 rules regardless of the Scala version we compile. I think we could
use something like
https://scalameta.org/scalafmt/docs/configuration.html#scala-2-with--xsource3.
##########
gradle.properties:
##########
@@ -31,3 +31,5 @@ swaggerVersion=2.2.8
task=build
org.gradle.jvmargs=-Xmx2g -Xss4m -XX:+UseParallelGC
org.gradle.parallel=true
+
+streamsScalaVersion=3.3.1
Review Comment:
This shouldn't be here I believe.
##########
gradle/dependencies.gradle:
##########
@@ -41,6 +42,20 @@ if (hasProperty('scalaVersion')) {
versions["scala"] = defaultScala212Version
}
+if (hasProperty('streamsScalaVersion')) {
+ if (streamsScalaVersion == '2.12') {
+ versions["streamsScala"] = defaultScala212Version
+ } else if (streamsScalaVersion == '2.13') {
+ versions["streamsScala"] = defaultScala213Version
+ } else if (streamsScalaVersion == '3') {
+ versions["streamsScala"] = defaultScala3Version
+ } else {
+ versions["streamsScala"] = streamsScalaVersion
+ }
+} else {
+ versions["streamsScala"] = defaultScala212Version
Review Comment:
This should be something like
```suggestion
versions["streamsScala"] = versions["scala"]
```
If you fail to specify `streamsScalaVersion` you should have the same
version as `scalaVersion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
