hachikuji commented on code in PR #15323:
URL: https://github.com/apache/kafka/pull/15323#discussion_r1483493757
##########
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##########
@@ -52,7 +52,7 @@ public class MetadataCache {
private final Map<TopicPartition, PartitionMetadata> metadataByPartition;
private final Map<String, Uuid> topicIds;
private final Map<Uuid, String> topicNames;
- private Cluster clusterInstance;
+ private InternalCluster clusterInstance;
Review Comment:
Discussed offline. It does not look like `PartitionMetadata` should be
treated as mutable. It comes directly from the Metadata response and I can't
think of a reason the client would update any of the replica sets directly. We
should confirm though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
