jolshan commented on code in PR #15348:
URL: https://github.com/apache/kafka/pull/15348#discussion_r1484689761
##########
checkstyle/suppressions.xml:
##########
@@ -336,11 +336,11 @@
<suppress checks="CyclomaticComplexity"
files="(ConsumerGroupMember|GroupMetadataManager|GeneralUniformAssignmentBuilder).java"/>
<suppress checks="(NPathComplexity|MethodLength)"
-
files="(GroupMetadataManager|ConsumerGroupTest|GroupMetadataManagerTest|GeneralUniformAssignmentBuilder).java"/>
+
files="(GroupMetadataManager|ConsumerGroupTest|GroupMetadataManagerTest|GroupMetadataManagerTestContext|GeneralUniformAssignmentBuilder).java"/>
Review Comment:
what's your take on in file suppressions vs suppressions.xml?
On a previous PR I was asked to make the supppression in file for specific
methods: https://github.com/apache/kafka/pull/15139#discussion_r1451075038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
