appchemist commented on code in PR #15296:
URL: https://github.com/apache/kafka/pull/15296#discussion_r1485088569
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,
ProduceResponse.PartitionRespons
"topic-partition may not exist or the user may not
have Describe access to it",
batch.topicPartition);
} else {
- log.warn("Received invalid metadata error in produce
request on partition {} due to {}. Going " +
+ log.warn("Received invalid metadata error in produce
request on partition {} due to {} Going " +
"to request metadata update now",
batch.topicPartition,
Review Comment:
How about including dot in Errors's `defaultExceptionString` that don't
currently include dot?
I referred to [Use grammatically correct error
messages](https://learn.microsoft.com/en-us/dotnet/standard/exceptions/best-practices-for-exceptions?redirectedfrom=MSDN#use-grammatically-correct-error-messages).
In addition, most Errors's `defaultExceptionString` already include dot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
