hgeraldino commented on code in PR #15313: URL: https://github.com/apache/kafka/pull/15313#discussion_r1485210009
########## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java: ########## @@ -343,6 +354,103 @@ public void testShutdown() throws Exception { verify(headerConverter).close(); } + @Test + public void testPollRedelivery() { + createTask(initialState); + expectTaskGetTopic(); + + when(consumer.assignment()).thenReturn(INITIAL_ASSIGNMENT); + INITIAL_ASSIGNMENT.forEach(tp -> when(consumer.position(tp)).thenReturn(FIRST_OFFSET)); + + workerTask.initialize(TASK_CONFIG); + workerTask.initializeAndStart(); + verifyInitializeTask(); + + expectPollInitialAssignment() + // If a retriable exception is thrown, we should redeliver the same batch, pausing the consumer in the meantime + .thenAnswer(expectConsumerPoll(1)) + // Retry delivery should succeed + .thenAnswer(expectConsumerPoll(0)) + .thenAnswer(expectConsumerPoll(1)) Review Comment: yep, that makes sense. removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org