mimaison commented on code in PR #14206:
URL: https://github.com/apache/kafka/pull/14206#discussion_r1489636848
##########
core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala:
##########
@@ -226,8 +226,8 @@ class ZkConfigMigrationClient(
val (migrationZkVersion, responses) =
zkClient.retryMigrationRequestsUntilConnected(requests, state)
if (responses.head.resultCode.equals(Code.NONODE)) {
- // Not fatal.
- error(s"Did not delete $configResource since the node did not exist.")
+ // Not fatal. This is expected in the case this is a topic config and
we delete the topic (KAFKA-16206)
Review Comment:
We usually don't include mention to Jiras. The explanation seems sufficient.
##########
metadata/src/test/java/org/apache/kafka/image/ClientQuotasImageTest.java:
##########
@@ -17,6 +17,7 @@
package org.apache.kafka.image;
+import java.util.Collections;
Review Comment:
Can we move this with the other `java.util` imports?
##########
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##########
@@ -64,6 +71,12 @@ public class ClusterImageTest {
final static ClusterImage IMAGE2;
+ static final List<ApiMessageAndVersion> DELTA2_RECORDS;
+
+ static final ClusterDelta DELTA2;
+
+ final static ClusterImage IMAGE3;
Review Comment:
nit: `static final` is the preferred syntax
##########
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##########
@@ -17,6 +17,11 @@
package org.apache.kafka.image;
+import org.apache.kafka.common.metadata.RegisterBrokerRecord;
Review Comment:
Can we move these imports with the other `org.apache.kafka.common.metadata`
imports below?
##########
metadata/src/test/java/org/apache/kafka/image/ConfigurationsImageTest.java:
##########
@@ -17,6 +17,7 @@
package org.apache.kafka.image;
+import java.util.Collections;
Review Comment:
Let's move this below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
