gharris1727 commented on PR #15367: URL: https://github.com/apache/kafka/pull/15367#issuecomment-1947714388
I realized that it was a bit silly both manually auditing these, and only fixing the Connect ones. I've instead addressed all of the unused suppressions by building a little audit script. It finds suppressions which: 1. Don't use the full name of the check, and instead use a shortened form 2. Include the same check and the same class as another suppression 3. Are missing, and the class has errors (this is what checkstyle normally does) 3. Are missing, the class has errors for, but a _shorter_ class name is listed in the suppressions 4. Are present, but the named class doesn't generate the corresponding error It's a rough-and-ready script, and doesn't handle the more powerful regexes in the suppressions file, only the basic ones composed of a single group. There are carve outs for the powerful regex hardcoded-in that prevent them from emitting spurious errors. I'll do my best to keep this rebased, but I would appreciate a quick review as people are currently adding new suppressions while this is open :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
