Cerchie commented on PR #14448:
URL: https://github.com/apache/kafka/pull/14448#issuecomment-1959710205
> Thanks for the PR. Overall LGTM.
>
> I am just wondering if we should also update the JavaDocs for all
deprecated configs? For example:
>
> ```
> /** {@code default.windowed.key.serde.inner} */
> @SuppressWarnings("WeakerAccess")
> @Deprecated
> public static final String DEFAULT_WINDOWED_KEY_SERDE_INNER_CLASS =
"default.windowed.key.serde.inner";
> ```
>
> We could change it to:
>
> ```
> /**
> * {@code default.windowed.key.serde.inner}
> * @deprecation Since X.y.0. Use {@link #WINDOWED_INNER_CLASS_SERDE}
instead.
> */
> @SuppressWarnings("WeakerAccess")
> @Deprecated
> public static final String DEFAULT_WINDOWED_KEY_SERDE_INNER_CLASS =
"default.windowed.key.serde.inner";
> ```
>
> Thought? We could do this for _all_ deprecated configs?
went through and addressed all the missing ones I found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
