lianetm commented on code in PR #15415:
URL: https://github.com/apache/kafka/pull/15415#discussion_r1499559758
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -744,16 +767,34 @@ public boolean isLeavingGroup() {
return state == MemberState.PREPARE_LEAVING || state ==
MemberState.LEAVING;
}
+ @Override
+ public void maybeRejoinStaleMember() {
+ if (state == MemberState.STALE) {
+ staleMemberAssignmentRelease.whenComplete((__, error) ->
transitionToJoining());
Review Comment:
Sure, good catch, done. We truly only need it when an expired poll timer is
reset. Note that I added the check in the HB (where I'm trying to keep the poll
timer logic), and the membershipMgr is only concern about the stale situation
(which is more than just the timer concept, because it includes the callbacks
that may take a while)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
