mimaison commented on code in PR #15295:
URL: https://github.com/apache/kafka/pull/15295#discussion_r1502397230
##########
core/src/test/scala/unit/kafka/server/epoch/EpochDrivenReplicationProtocolAcceptanceTest.scala:
##########
@@ -53,17 +58,26 @@ class EpochDrivenReplicationProtocolAcceptanceTest extends
QuorumTestHarness wit
val topic = "topic1"
val msg = new Array[Byte](1000)
val msgBigger = new Array[Byte](10000)
- var brokers: Seq[KafkaServer] = _
+ var brokers: Seq[KafkaBroker] = _
var producer: KafkaProducer[Array[Byte], Array[Byte]] = _
var consumer: Consumer[Array[Byte], Array[Byte]] = _
+ private def securityProtocol: SecurityProtocol = SecurityProtocol.PLAINTEXT
+ private def listenerName: ListenerName =
ListenerName.forSecurityProtocol(securityProtocol)
+
@BeforeEach
override def setUp(testInfo: TestInfo): Unit = {
+ if (TestInfoUtils.isKRaft(testInfo) &&
metadataVersion.isLessThan(IBP_3_3_IV0)) {
Review Comment:
Can you explain why we need this change? `metadataVersion` is hard coded to
`MetadataVersion.latestTesting`, how can it be less than `IBP_3_3_IV0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
