cadonna commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1507315536
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ########## @@ -32,36 +36,42 @@ public enum Type { private final Type type; + /** + * This identifies a particular event. It is used to disambiguate events via {@link #hashCode()} and + * {@link #equals(Object)} and can be used in log messages when debugging. + */ + private final Uuid id; Review Comment: > I wanted the IDs to be "globally unique", which isn't going to happen if the client logs include multiple consumers. Perhaps that's an over-optimization? I hope the log context will tell you from what consumer the events come from. However, I also agree that searching for globally unique IDs in logs is easier than searching for counters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org