lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1507409271
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -524,10 +524,10 @@ public void testHeartbeatState() {
assertEquals(memberId, data.memberId());
assertEquals(0, data.memberEpoch());
assertNull(data.instanceId());
- assertEquals(-1, data.rebalanceTimeoutMs());
Review Comment:
The ticket asks for an extension of this test:
> Note that the existing HeartbeatRequestManagerTest.testHeartbeatState
misses this exact case given that it does explicitly change the subscription
when it gets fenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
