mjsax commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1508477877
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1277,8 +1280,7 @@ void prepareShutdown(final Timer timer, final
AtomicReference<Throwable> firstEx
// Visible for testing
void maybeAutoCommitSync(final boolean shouldAutoCommit,
- final Timer timer,
- final AtomicReference<Throwable> firstException) {
Review Comment:
> it looks like it is correct to only log the error here.
Why? Should we not set `firstException` if `null` and `commitSync` throws?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
