mjsax commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1509672158
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1140,6 +1145,7 @@ public class StreamsConfig extends AbstractConfig {
static {
final Map<String, Object> tempProducerDefaultOverrides = new
HashMap<>();
tempProducerDefaultOverrides.put(ProducerConfig.LINGER_MS_CONFIG,
"100");
+
tempProducerDefaultOverrides.put(ProducerConfig.PARTITIONER_CLASS_CONFIG,
"none");
Review Comment:
Default is already `null` -- why do we need to set it?
##########
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##########
@@ -530,6 +530,14 @@ public void
shouldSetInternalLeaveGroupOnCloseConfigToFalseInConsumer() {
assertThat(consumerConfigs.get("internal.leave.group.on.close"),
is(false));
}
+ @Test
+ public void
shouldResetToDefaultIfConsumerAllowAutoCreateTopicsIsOverridden() {
Review Comment:
This should apply to all consumers, right? Should we extend the test
accordingly?
Should we also capture the logs and verify that the WARN is printed (not
sure if necessary)?
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1883,3 +1886,20 @@ public static void main(final String[] args) {
System.out.println(CONFIG.toHtml(4, config -> "streamsconfigs_" +
config));
}
}
+
+
+ public Map<String, Object> getMainConsumerConfigs(...) {
Review Comment:
`StreamsConfig` is public API and we cannot just modify it w/o a KIP. --
Also, why do we need this new method to begin with? We already have
`getMainConsumerConfigs(...)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
