AyoubOm commented on PR #15395: URL: https://github.com/apache/kafka/pull/15395#issuecomment-1976087470
> Thanks for the PR! Overall LGTM, but we should add a unit test for the newly added sensor. Thanks @mjsax for your review. I added tests of the dropped record sensor (I believed we didn't have access to metrics from the context but we have indeed). Another point, I think there are some missing tests in the foreignkeyjoin package, and problems in naming a test class. For example, `ForeignTableJoinProcessorSupplierTest` is not testing `ForeignTableJoinProcessorSupplier` but `SubscriptionJoinProcessorSupplier`. Hence, I think the ForeignTableJoinProcessorSupplier is not tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
