chia7712 commented on code in PR #15467:
URL: https://github.com/apache/kafka/pull/15467#discussion_r1511553088
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java:
##########
@@ -901,7 +901,7 @@ public RebalanceResult staticMembersJoinAndRebalance(
public PendingMemberGroupResult setupGroupWithPendingMember(ClassicGroup
group) throws Exception {
// Add the first member
JoinGroupRequestData joinRequest = new JoinGroupRequestBuilder()
- .withGroupId("group-id")
+ .withGroupId(group.groupId())
Review Comment:
(this is unrelated to this PR)
The caller `GroupMetadataManagerTest` has similar issue
(https://github.com/apache/kafka/blob/trunk/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java#L7631).
Should it get fixed also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
