chia7712 commented on code in PR #15387:
URL: https://github.com/apache/kafka/pull/15387#discussion_r1511863661
##########
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##########
@@ -29,7 +29,7 @@
import org.apache.kafka.common.utils.Utils;
public final class ServerTopicConfigSynonyms {
- private static final String LOG_PREFIX = "log.";
+ public static final String LOG_PREFIX = "log.";
private static final String LOG_CLEANER_PREFIX = LOG_PREFIX + "cleaner.";
Review Comment:
Sorry that I meant `CleanerConfig` can use `LOG_CLEANER_PREFIX` instead of
`LOG_PREFIX`. For example:
```java
ServerTopicConfigSynonyms.LOG_PREFIX + "cleaner.threads";
```
could be replaced by
```java
ServerTopicConfigSynonyms.LOG_CLEANER_PREFIX + "threads";
```
It seems to me the later is more readable. Or `CleanerConfig` can have a new
constant "LOG_CLEANER_PREFIX"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
