gharris1727 commented on PR #15469: URL: https://github.com/apache/kafka/pull/15469#issuecomment-1977794542
Benchmark | Before ns/op | Before Error | After ns/op | After Error | Speedup -- | -- | -- | -- | -- | -- ValuesBenchmark.testConvertToBoolean | 124.038 | 0.319 | 71.448 | 2.258 | 1.7 ValuesBenchmark.testConvertToByte | 111.404 | 2.196 | 61.334 | 0.092 | 1.8 ValuesBenchmark.testConvertToDate | 3698.989 | 135.292 | 3675.007 | 5.379 | 1.0 ValuesBenchmark.testConvertToDecimal | 1433.731 | 20.883 | 1515.147 | 2.91 | 0.9 ValuesBenchmark.testConvertToDouble | 196.389 | 68.131 | 59.401 | 0.357 | 3.3 ValuesBenchmark.testConvertToFloat | 329.249 | 158.87 | 56.547 | 0.43 | 5.8 ValuesBenchmark.testConvertToInteger | 130.939 | 0.479 | 64.801 | 0.465 | 2.0 ValuesBenchmark.testConvertToList | 1212.389 | 19.245 | 1527.234 | 2.949 | 0.8 ValuesBenchmark.testConvertToLong | 131.72 | 2.178 | 75.345 | 0.434 | 1.7 ValuesBenchmark.testConvertToMap | 1641.567 | 27.802 | 1890.402 | 12.093 | 0.9 ValuesBenchmark.testConvertToShort | 113.9 | 0.254 | 61.587 | 0.199 | 1.8 ValuesBenchmark.testConvertToString | 1620.263 | 8.395 | 1669.339 | 3.622 | 1.0 ValuesBenchmark.testConvertToStruct | 3.768 | 0.034 | 1.374 | 0.013 | 2.7 ValuesBenchmark.testConvertToTime | 2775.386 | 8.146 | 2685.46 | 8.681 | 1.0 ValuesBenchmark.testConvertToTimestamp | 2849.605 | 7.025 | 2731.251 | 6.568 | 1.0 ValuesBenchmark.testInferSchema | 116.758 | 0.133 | 97.536 | 0.325 | 1.2 ValuesBenchmark.testParseString | 41501.659 | 197.842 | 13606.346 | 287.035 | 3.1 This has some irregularities. The floating point tests were multi-modal, but it don't appear to be with the new implementation, i'm not sure why. ``` # Benchmark: org.apache.kafka.jmh.connect.ValuesBenchmark.testConvertToFloat # Warmup Iteration 1: 280.384 ns/op # Warmup Iteration 2: 133.229 ns/op # Warmup Iteration 3: 132.223 ns/op Iteration 1: 430.475 ns/op Iteration 2: 284.555 ns/op Iteration 3: 273.401 ns/op Iteration 4: 328.282 ns/op Iteration 5: 237.622 ns/op Iteration 6: 344.620 ns/op Iteration 7: 405.791 ns/op # Benchmark: org.apache.kafka.jmh.connect.ValuesBenchmark.testConvertToDouble # Warmup Iteration 1: 200.209 ns/op # Warmup Iteration 2: 138.782 ns/op # Warmup Iteration 3: 195.215 ns/op Iteration 1: 196.872 ns/op Iteration 2: 192.461 ns/op Iteration 3: 200.401 ns/op Iteration 4: 216.845 ns/op Iteration 5: 195.567 ns/op Iteration 6: 137.116 ns/op Iteration 7: 235.458 ns/op ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
