kirktrue commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1513571996
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##########
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture<TopicPartition,
DeletedRecords> newFuture(
@Override
public DeleteRecordsRequest.Builder buildBatchedRequest(int brokerId,
Set<TopicPartition> keys) {
Map<String, DeleteRecordsRequestData.DeleteRecordsTopic>
deletionsForTopic = new HashMap<>();
- for (Map.Entry<TopicPartition, RecordsToDelete> entry:
recordsToDelete.entrySet()) {
- TopicPartition topicPartition = entry.getKey();
+ for (TopicPartition topicPartition : keys) {
+ RecordsToDelete toDelete = recordsToDelete.get(topicPartition);
DeleteRecordsRequestData.DeleteRecordsTopic deleteRecords =
deletionsForTopic.computeIfAbsent(
topicPartition.topic(),
key -> new
DeleteRecordsRequestData.DeleteRecordsTopic().setName(topicPartition.topic())
);
deleteRecords.partitions().add(new
DeleteRecordsRequestData.DeleteRecordsPartition()
.setPartitionIndex(topicPartition.partition())
- .setOffset(entry.getValue().beforeOffset()));
+ .setOffset(toDelete.beforeOffset()));
Review Comment:
Would it be unduly paranoid to check for `null` before accessing `toDelete`?
The call stack up to this point is pretty twisty. I'm assuming that `keys`
_shouldn't_ contain any `TopicPartition`s that aren't keys in
`recordsToDelete`, but... 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
