KevinZTW commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1513701081


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##########
@@ -431,6 +432,7 @@ public interface LiteralSupplier<T> {
      * @param args the arguments
      */
     public static void main(String[] args) {
+        LogManager.shutdown();

Review Comment:
   Sorry took a while to check this. I think it is because usually in our 
project, the `StaticLoggerBinder` is provided by `slf4j-reload4j` and In the 
Gradle build file, the project `:connect:runtime` adds that as test runtime 
only. 
   
   Hence, if we specify the `classpath` as `main` runtime, the path where 
`slf4j-reload4j`'s jar file is located won't be included. Hence cause the SL4J 
change to use NOP logger implementation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to