jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520171958
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1796,12 +1834,12 @@ public void onLoaded() {
consumerGroup.members().forEach((memberId, member) -> {
log.debug("Loaded member {} in consumer group {}.",
memberId, groupId);
scheduleConsumerGroupSessionTimeout(groupId, memberId);
- if (member.state() ==
ConsumerGroupMember.MemberState.REVOKING) {
- scheduleConsumerGroupRevocationTimeout(
+ if (member.state() ==
MemberState.UNREVOKED_PARTITIONS) {
+ scheduleConsumerGroupRebalanceTimeout(
groupId,
- memberId,
- member.rebalanceTimeoutMs(),
- member.memberEpoch()
+ member.memberId(),
Review Comment:
did we change this from memberId to member.memberId just to be consistent
with the other arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
