divijvaidya commented on PR #15523: URL: https://github.com/apache/kafka/pull/15523#issuecomment-1994553843
Nice fix @kamalcph! A few questions: 1. Why did we create a new test file. Can't we add the tests to existing `ShutdownableThreadTest` https://github.com/apache/kafka/blob/trunk/core/src/test/scala/unit/kafka/utils/ShutdownableThreadTest.scala ? 2. If the cleaner thread wasn't even started, are our really testing correct behaviour? For example, when we validate that cleaner shouldn't have deleted something, we would happily think that cleaner ran but didn't delete stuff whereas in reality, it may never have run at all. Should we instead add a wait loop in our setup for cache in the test to ensure that cleaner starts running? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
