dajac commented on code in PR #15528:
URL: https://github.com/apache/kafka/pull/15528#discussion_r1523579678
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -593,7 +595,8 @@ public List<DescribeGroupsResponseData.DescribedGroup>
describeGroups(
*/
ConsumerGroup getOrMaybeCreateConsumerGroup(
String groupId,
- boolean createIfNotExists
+ boolean createIfNotExists,
+ boolean addToGroupsMap
Review Comment:
I am not a fan of this new boolean flag because there is a change of
misusing it. Have you considered keeping `getOrMaybeCreateConsumerGroup` on the
`consumerGroupHeartbeat` path (without the part which adds to the map) and
change the replay logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
