lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1523863939


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -683,7 +681,10 @@ public void testDelayedMetadataUsedToCompleteAssignment() {
         receiveAssignment(newAssignment, membershipManager);
         membershipManager.poll(time.milliseconds());
 
-        verifyReconciliationNotTriggered(membershipManager);
+        // We bumped the local epoch, so new reconciliation is triggered

Review Comment:
   This new reconciliation triggered is an example of what I was referring to 
in the [comment](https://github.com/apache/kafka/pull/15511/files#r1523858796) 
above, that seems to complicate the flow with 2 rebalances instead of 1. I 
wouldn't expect a member rebalancing/reconciling at this point (nothing changed 
for him yet, t2 not in metadata), and then reconciling/rebalance again once it 
discovers it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to