ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1523907637
##########
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##########
@@ -35,24 +35,12 @@ public class BoundedList<E> implements List<E> {
private final int maxLength;
private final List<E> underlying;
- public static <E> BoundedList<E> newArrayBacked(int maxLength) {
- return new BoundedList<>(maxLength, new ArrayList<>());
- }
-
- public static <E> BoundedList<E> newArrayBacked(int maxLength, int
initialCapacity) {
- return new BoundedList<>(maxLength, new ArrayList<>(initialCapacity));
- }
-
- public BoundedList(int maxLength, List<E> underlying) {
+ public BoundedList(int maxLength) {
if (maxLength <= 0) {
throw new IllegalArgumentException("Invalid non-positive maxLength
of " + maxLength);
}
this.maxLength = maxLength;
- if (underlying.size() > maxLength) {
- throw new BoundedListTooLongException("Cannot wrap list, because
it is longer than " +
- "the maximum length " + maxLength);
- }
- this.underlying = underlying;
+ this.underlying = new ArrayList<>(maxLength);
Review Comment:
Sorry I am confused on what you want to change to `private`? Today, passing
in the source list is only used in unit tests, not any source code. If it's
only used for unit tests I think it should be removed so that tests interact
with the BoundedList the same way the source code does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
