chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524140865
##########
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##########
@@ -35,24 +35,12 @@ public class BoundedList<E> implements List<E> {
private final int maxLength;
private final List<E> underlying;
- public static <E> BoundedList<E> newArrayBacked(int maxLength) {
- return new BoundedList<>(maxLength, new ArrayList<>());
- }
-
- public static <E> BoundedList<E> newArrayBacked(int maxLength, int
initialCapacity) {
Review Comment:
> I like the idea of migrating newArrayBacked(int maxLength) to
newLinkedListBacked(int maxLength), this would also help cut down on array list
resizing time, as currently this constructor creates a default array list,
which is size 10
I did not suggest to use Linked list for current usage 🫢
My point was keeping the constructor can have flexibility of changing the
list implementation in the future
We need to consider the cost of iteration before adopting the linked list.
To simplify this PR and address the origin propose, changing the scope from
public to private is good enough. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
