swuferhong opened a new pull request, #15544:
URL: https://github.com/apache/kafka/pull/15544
This pr is aims to fix the wrong highWatermark assert equals condition in
`HighwatermarkPersistenceTest`. The highWatermark need lower than LEO, but in
`HighwatermarkPersistenceTest#testHighWatermarkPersistenceSinglePartition`, the
test not append only data to partition, so `updateHighWatermark()` cannot work,
the `hw` are always 0.
However, the test don't failed before because of the assert equals condition
is self judgement which will be always true (equals to 0).
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
