pasharik commented on code in PR #15404: URL: https://github.com/apache/kafka/pull/15404#discussion_r1530262197
########## gradle/dependencies.gradle: ########## @@ -100,10 +100,10 @@ versions += [ commonsCli: "1.4", commonsValidator: "1.7", dropwizardMetrics: "4.1.12.1", - gradle: "8.5", + gradle: "8.6", Review Comment: @jlprat my `trunk` branch was almost 2 weeks old, now I've updated it and I can't see any difference between Gradle 8.5 and 8.6. So I think we can leave this PR as it is, sorry for the confusion. I didn't report issue to the Gradle yet, still trying to figure out exact steps how to reproduce it, and if it's related to Gradle or to my local environment setup. Not related to this particular PR, but I still can see issues with incremental compilation, only when making changes from IntelliJ Idea. If changes are made from vim or other console text editor, incremental compilation works as expected. Steps to reproduce: * Open `kafka.admin.AclCommandTest` in IntelliJ Idea. I'm using `2023.3.5 Ultimate` * Add `println("a")` at the beginning of `testAclCliWithAuthorizer` method * Run in terminal: `./gradlew core:test --tests "kafka.admin.AclCommandTest.testAclCliWithAuthorizer"` * Result: all tests in `core` module are re-compiled If test modified with `vim`, only single test class is re-compiled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org