dajac commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1530443218
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -619,6 +622,22 @@ ConsumerGroup getOrMaybeCreateConsumerGroup(
}
}
+ /**
+ * Gets a consumer group.
+ *
+ * @param groupId The group id.
+ *
+ * @return A ConsumerGroup.
+ * @throws GroupIdNotFoundException if the group does not exist or the
group is not a consumer group.
+ *
+ * Package private for testing.
+ */
+ ConsumerGroup getConsumerGroup(
Review Comment:
I just noticed that we also have `consumerGroup(String, long)` as a method.
I wonder whether we should also name this one `consumerGroup` too and call the
one that I mentioned. It would also make sense to regroup them. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
