ijuma commented on code in PR #15565: URL: https://github.com/apache/kafka/pull/15565#discussion_r1532671434
########## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ########## @@ -586,7 +586,7 @@ private void handleProduceResponse(ClientResponse response, Map<TopicPartition, log.trace("Cancelled request with header {} due to the last request to node {} timed out", requestHeader, response.destination()); for (ProducerBatch batch : batches.values()) - completeBatch(batch, new ProduceResponse.PartitionResponse(Errors.REQUEST_TIMED_OUT, String.format("Disconnected from node %s due to timeout", response.destination())), + completeBatch(batch, new ProduceResponse.PartitionResponse(Errors.NETWORK_EXCEPTION, String.format("Disconnected from node %s due to request timeout", response.destination())), Review Comment: Please add a comment clarifying that this cannot be REQUEST_TIMEOUT even though the message says so -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org