squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1535637194
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -921,7 +921,10 @@ private[group] class GroupCoordinator(
): Unit = {
val (error, verificationGuard) = errorAndGuard
if (error != Errors.NONE) {
- val finalError =
GroupMetadataManager.maybeConvertOffsetCommitError(error)
+ val finalError = error match {
+ case Errors.NETWORK_EXCEPTION =>
Errors.COORDINATOR_LOAD_IN_PROGRESS
Review Comment:
I've added a comment and moved the error translation in the old group
coordinator to `maybeConvertOffsetCommitError`.
I also moved the error translation in the new group coordinator to
`handleOperationException` based on feedback from @\dajac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
