chia7712 commented on code in PR #15582:
URL: https://github.com/apache/kafka/pull/15582#discussion_r1536587007


##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -1540,15 +1540,14 @@ public void 
testActivationRecordsPartialBootstrap(boolean zkMigrationEnabled) {
     @Test
     public void testMigrationsEnabledForOldBootstrapMetadataVersion() throws 
Exception {
         try (
-            LocalLogManagerTestEnv logEnv = new 
LocalLogManagerTestEnv.Builder(1).build()
+            LocalLogManagerTestEnv logEnv = new 
LocalLogManagerTestEnv.Builder(1).build();
         ) {
-            QuorumControllerTestEnv.Builder controlEnvBuilder = new 
QuorumControllerTestEnv.Builder(logEnv).
-                    setControllerBuilderInitializer(controllerBuilder -> {
-                        controllerBuilder.setZkMigrationEnabled(true);
-                    }).
-                    
setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_3_IV0, 
"test"));
-
-            QuorumControllerTestEnv controlEnv = controlEnvBuilder.build();
+            QuorumControllerTestEnv controlEnv = new 
QuorumControllerTestEnv.Builder(logEnv).
+                setControllerBuilderInitializer(controllerBuilder -> {
+                    controllerBuilder.setZkMigrationEnabled(true);
+                }).
+                
setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_3_IV0, 
"test")).
+                build();

Review Comment:
   `;` is unnecessary



##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -1540,15 +1540,14 @@ public void 
testActivationRecordsPartialBootstrap(boolean zkMigrationEnabled) {
     @Test
     public void testMigrationsEnabledForOldBootstrapMetadataVersion() throws 
Exception {
         try (
-            LocalLogManagerTestEnv logEnv = new 
LocalLogManagerTestEnv.Builder(1).build()
+            LocalLogManagerTestEnv logEnv = new 
LocalLogManagerTestEnv.Builder(1).build();
         ) {
-            QuorumControllerTestEnv.Builder controlEnvBuilder = new 
QuorumControllerTestEnv.Builder(logEnv).
-                    setControllerBuilderInitializer(controllerBuilder -> {
-                        controllerBuilder.setZkMigrationEnabled(true);
-                    }).
-                    
setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_3_IV0, 
"test"));
-
-            QuorumControllerTestEnv controlEnv = controlEnvBuilder.build();
+            QuorumControllerTestEnv controlEnv = new 
QuorumControllerTestEnv.Builder(logEnv).
+                setControllerBuilderInitializer(controllerBuilder -> {

Review Comment:
   the `{` can be omitted



##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -1658,12 +1657,12 @@ public void 
testActivationRecordsPartialTransactionNoSupport() {
     @Test
     public void testFailoverDuringMigrationTransaction() throws Exception {
         try (
-            LocalLogManagerTestEnv logEnv = new 
LocalLogManagerTestEnv.Builder(3).build()
-        ) {
-            QuorumControllerTestEnv.Builder controlEnvBuilder = new 
QuorumControllerTestEnv.Builder(logEnv).
+            LocalLogManagerTestEnv logEnv = new 
LocalLogManagerTestEnv.Builder(3).build();
+            QuorumControllerTestEnv controlEnv = new 
QuorumControllerTestEnv.Builder(logEnv).
                 setControllerBuilderInitializer(controllerBuilder -> 
controllerBuilder.setZkMigrationEnabled(true)).
-                
setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_6_IV1, 
"test"));
-            QuorumControllerTestEnv controlEnv = controlEnvBuilder.build();
+                
setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_6_IV1, 
"test")).
+                build();

Review Comment:
   `;` is unnecessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to