AndrewJSchofield commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1536692361
##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -42,14 +42,26 @@ object AddPartitionsToTxnManager {
val VerificationTimeMsMetricName = "VerificationTimeMs"
}
+/**
+ * This is an enum which handles the Partition Response based on the Request
Version and the exact operation
+ * defaultError: This is the default workflow which maps to cases
when the Produce Request Version or the Txn_offset_commit request was lower
than the first version supporting the new Error Class
+ * genericError: This maps to the case when the clients are updated
to handle the AbortableTxnException
Review Comment:
I think it's not `AbortableTxnException`. Probably ought to give it its
proper name.
##########
clients/src/main/java/org/apache/kafka/common/errors/AbortableTransactionException.java:
##########
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.common.errors;
+
+public class AbortableTransactionException extends ApiException {
Review Comment:
I tend to agree that `TransactionAbortableException` is very slightly more
satisfying than `AbortableTransactionException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
