gharris1727 commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1540167974
##########
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##########
@@ -547,6 +552,17 @@ private Map<String, String>
extractPotentialVariables(Map<?, ?> configMap) {
return new ResolvingMap<>(resolvedOriginals, originals);
}
+ private Predicate<String> automaticConfigProvidersFilter() {
+ String systemProperty =
System.getProperty(AUTOMATIC_CONFIG_PROVIDERS_PROPERTY);
+ if (systemProperty == null) {
+ return ignored -> true;
+ } else {
+ return Arrays.stream(systemProperty.split(","))
Review Comment:
The next line trims the whitespace from the strings, so we should already be
permissive.
I see that ConfigDef uses `"\\s*,\\s*"` for List properties, while
AbstractConfig uses `","` _without_ trim for `config.providers`. That's not
great, but that's also not affected by this PR.
Since `ConfigDef.COMMA_WITH_WHITESPACE` is private, I think i'll leave this
as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
