mimaison commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1540885105
########## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ########## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.server.config; + +import org.apache.kafka.common.config.TopicConfig; +import static org.apache.kafka.server.config.ServerTopicConfigSynonyms.LOG_PREFIX; + +public class KafkaConfig { + + /** ********* Log Configuration ***********/ + public final static String NUM_PARTITIONS_PROP = "num.partitions"; Review Comment: Would it also make sense to colocate the `CONFIG` and `DOC` like we do in the other Config classes? ########## core/src/main/scala/kafka/server/ZkAdminManager.scala: ########## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S import org.apache.kafka.common.utils.Sanitizer import org.apache.kafka.server.common.AdminOperationException import org.apache.kafka.server.config.{ConfigEntityName, ConfigType} +import org.apache.kafka.server.config.KafkaConfig._ Review Comment: I wonder if we should just import `KafkaConfig` and use `KAFKA.SOME_CONFIG` instead of importing all/statically KafkaConfig. WDYT? ########## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ########## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.server.config; + +import org.apache.kafka.common.config.TopicConfig; +import static org.apache.kafka.server.config.ServerTopicConfigSynonyms.LOG_PREFIX; + +public class KafkaConfig { + + /** ********* Log Configuration ***********/ + public final static String NUM_PARTITIONS_PROP = "num.partitions"; Review Comment: For consistency with the other *Configs classes, should we used the `CONFIG` suffix instead of `PROP`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
