jeqo commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022623732
Sorry for also being later with the review. Changes look good to me overall, though I'd also add a mention on these configs that: `log.roll` configs are ignored (as well as the mentioned `segment.bytes|ms`). We could address this as part of KAFKA-16429 if you agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
