lucasbru commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543068952
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1360,6 +1367,9 @@ public void commitSync(Map<TopicPartition,
OffsetAndMetadata> offsets, Duration
Timer requestTimer = time.timer(timeout.toMillis());
SyncCommitEvent syncCommitEvent = new SyncCommitEvent(offsets,
requestTimer);
CompletableFuture<Void> commitFuture = commit(syncCommitEvent);
+
+ invokePendingAsyncCommits(requestTimer, false);
Review Comment:
In principle, this is only needed in the case where offsets are empty,
because otherwise the commitSync itself should make sure that all previous
asynccommits are completed, since the commit requests are ordered and going to
the same connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
