junrao commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2027526301
> Do we need to revert all of them? the paths we had fixed works well now. > > 1. It seems to me adding comments for both "recover" and "follower" cases can remind readers that this offsetOfMaxTimestampMs is shallow. > 2. or we can only rename offsetForMaxTimestamp back to shallowOffsetMaxTimestamp but we keep the implementation. > @chia7712 : I think both are important. First, it's important to be able to derive the same thing consistently from the leader and the follower log. This affects things like the time indexing entries. It will be confusing if the leader adds an offset in the middle of a batch while the follower adds an offset at the end of the batch. Second, it's our responsibility name things as accurately as possible. Otherwise, future developers could make inaccurate assumptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
