johnnychhsu commented on PR #15463: URL: https://github.com/apache/kafka/pull/15463#issuecomment-2029543783
@kamalcph thanks for the comment, and sorry for the late reply. Previously we get the counts from the yammer metrics, however, although the `onExpire` has called the `mark`, the counter value was not updated. I have tried to log the process and observe the behaviour, everything want as expected, but the metrics still didn't reflect. After discussion with @showuon , we found that the potential reason could be, that metrics was affected by other tests, because all those tests run in the same JVM. By change the way we verify the metrics, the updated test can still cover the original test case, but without the flaky issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
